Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to override VideoView's rotation (iOS) #122

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Ability to override VideoView's rotation (iOS) #122

merged 2 commits into from
Aug 25, 2022

Conversation

hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Aug 24, 2022 •
edited
Loading

Only works for iOS at the moment.

macOS can be supported after webrtc-sdk/webrtc#40 gets merged.

davidzhao
davidzhao approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! CC @davidliu too as a potential thing for Android

@hiroshihorie hiroshihorie changed the title Ability to override VideoView's rotation Ability to override VideoView's rotation (iOS) Aug 25, 2022
@hiroshihorie hiroshihorie merged commit aa3902f into main Aug 25, 2022
@hiroshihorie hiroshihorie deleted the video-rotation branch August 25, 2022 06:54
@davidliu davidliu mentioned this pull request Aug 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

@cloudwebrtc cloudwebrtc Awaiting requested review from cloudwebrtc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiroshihorie @davidzhao