Fix loudspeaker usage during playback only #485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For use cases like live streaming watching, using playAndRecord means we can't lower the audio all the way down. Is it when .play the audio isn't loud ? |
|
closing in favor of #486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that prior to #477 a bug existed where mute/unmute would not necessarily cause audio session reconfiguring, which masked an issue with the session configuration.
To get the system to use the loudspeaker and receiver together, at max available volume, the only reliable method I have found is using the
.playAndRecordcategory with the.videoChatmode. This was set when the microphone was unmuted, but upon mute it reverted to.playbackwith.spokenAudio. That caused a significant drop in apparent audio as only the receiver would be used.We already used
.playAndRecord(with.voiceChat) in the case that you had a muted microphone but a preference to not use the speaker, so it was possible to simplify things significantly here and unify the code.I've tested it a bit but more testing and insight would be appreciated @hiroshihorie!