Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust sdk, add dtmf and attributes support #239

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Update rust sdk, add dtmf and attributes support #239

merged 7 commits into from
Jul 18, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Jul 17, 2024

depends on livekit/rust-sdks#371

and pulls in latest changes on main of rust sdk, which comes with a couple of necessary ffi protocol changes.

~~the submodule currently points to the lukas/add-publish-dtmf branch. Should update that after that PR got merged to point to main instead. ~~ ✅

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: cd92013

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@livekit/rtc-node Minor
@livekit/rtc-node-darwin-arm64 Minor
@livekit/rtc-node-darwin-x64 Minor
@livekit/rtc-node-linux-arm64-gnu Minor
@livekit/rtc-node-linux-x64-gnu Minor
@livekit/rtc-node-win32-x64-msvc Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested a review from theomonnom July 17, 2024 13:10
@lukasIO lukasIO requested a review from nbsp July 18, 2024 10:29
@lukasIO
Copy link
Contributor Author

lukasIO commented Jul 18, 2024

@nbsp also added support for retrieving attribute events (which I think wasn't yet part of #240 ?)

@lukasIO lukasIO changed the title Update rust sdk and add dtmf support Update rust sdk, add dtmf and attributes support Jul 18, 2024
//
// SPDX-License-Identifier: Apache-2.0

export function diffAttributes(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah awesome!
cc @keepingitneil, we should do the same for livekit/python-sdks#217

Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🔥

@lukasIO lukasIO merged commit 3b40e58 into main Jul 18, 2024
8 checks passed
@lukasIO lukasIO deleted the lukas/dtmf branch July 18, 2024 12:41
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants