-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rust sdk, add dtmf and attributes support #239
Conversation
🦋 Changeset detectedLatest commit: cd92013 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
export function diffAttributes( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah awesome!
cc @keepingitneil, we should do the same for livekit/python-sdks#217
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🔥
depends on livekit/rust-sdks#371
and pulls in latest changes on main of rust sdk, which comes with a couple of necessary ffi protocol changes.
~~the submodule currently points to the
lukas/add-publish-dtmf
branch. Should update that after that PR got merged to point to main instead. ~~ ✅