fix: simplify A2T return_timestamps type #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
force-pushed
the
improve_return_timestamps_type
branch
from
dfef016
to
cd6dcd8
Compare
In the previous pull request, I adhered to the union type used by Whisper, but this caused issues in the multipart handling. To avoid complicating the MultiPartWriter, this commit converts the union type to a string. This change simplifies the multipart handling and user confusion.
rickstaa
force-pushed
the
improve_return_timestamps_type
branch
from
cd6dcd8
to
72e7c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous pull request, I adhered to the union type used by Whisper, but this caused issues in the multipart handling. To avoid complicating the MultiPartWriter, this commit converts the union type to a string. This change simplifies the multipart handling and user confusion.