fix(runner): update img2img to do sequential processing of batch request #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reserving comment: Will test when have some time. Papabear has some test data from running batches that provides that there is no significant efficiency gain running the requested images in parallel. |
rickstaa
approved these changes
Jun 5, 2024
|
@ad-astra-video I made some small changes to make the I2I code more similar to the T2I pipeline code. The change looks good to me feel free to merge this and release it under version v0.0.7. |
This commit enhances the consistency between the I2I and T2I pipelines, making them easier to compare.
rickstaa
force-pushed
the
av-img2img-sequential-processing
branch
from
798953b
to
21b8d4f
Compare
eliteprox
pushed a commit
to eliteprox/ai-worker
that referenced
this pull request
Jun 9, 2024
…est (livepeer#95) * update img2img to do sequential processing of batch request * refactor(runner): improve consistency between I2I and T2I pipelines This commit enhances the consistency between the I2I and T2I pipelines, making them easier to compare. --------- Co-authored-by: Rick Staa <[email protected]>
eliteprox
pushed a commit
to eliteprox/ai-worker
that referenced
this pull request
Jul 26, 2024
…est (livepeer#95) * update img2img to do sequential processing of batch request * refactor(runner): improve consistency between I2I and T2I pipelines This commit enhances the consistency between the I2I and T2I pipelines, making them easier to compare. --------- Co-authored-by: Rick Staa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the image-to-image router in runner to process the batch requests sequentially. Similar to text-to-image, this will stabilize GPU memory usage and allow for some GPUs to run multiple instances of lighter weight models.