Address some TODOs #119
Merged
Address some TODOs #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomshutt
commented
Oct 31, 2022
| @@ -41,8 +41,6 @@ func (d *CatalystAPIHandlersCollection) TranscodeSegment() httprouter.Handle { | |||
| if err != nil { | |||
| errors.WriteHTTPInternalServerError(w, "Error running Transcode process", err) | |||
| } | |||
|
|
|||
| // TODO: Success callback to Studio | |||
There was a problem hiding this comment.
This now happens inside the transcode method itself
thomshutt
commented
Oct 31, 2022
| @@ -112,7 +112,6 @@ func (d *CatalystAPIHandlersCollection) UploadVOD() httprouter.Handle { | |||
| } | |||
|
|
|||
| func (d *CatalystAPIHandlersCollection) processUploadVOD(streamName, sourceURL, targetURL string) error { | |||
| // TODO: remove this logic to force input URLs to mp4/mov format | |||
There was a problem hiding this comment.
I think we're keeping this for now
thomshutt
commented
Oct 31, 2022
| @@ -77,7 +77,7 @@ func GenerateAndUploadManifests(sourceManifest m3u8.MediaPlaylist, targetOSURL s | |||
| masterPlaylist.Append( | |||
| fmt.Sprintf("rendition-%d/rendition.m3u8", i), | |||
| &m3u8.MediaPlaylist{ | |||
| TargetDuration: 10, // TODO: Don't hardcode | |||
| TargetDuration: sourceManifest.TargetDuration, | |||
There was a problem hiding this comment.
Can just take it off the source manifest, since we're not forcing a different TargetDuration at this point
thomshutt
commented
Oct 31, 2022
| @@ -92,7 +92,6 @@ func RunTranscodeProcess(transcodeRequest TranscodeSegmentRequest, streamName st | |||
| } | |||
|
|
|||
| // Iterate through the segment URLs and transcode them | |||
| // TODO: Some level of parallelisation once we're happy this works well | |||
There was a problem hiding this comment.
This is now being tracked under #111 so we can ditch the TODO
emranemran
approved these changes
Oct 31, 2022
iameli
added a commit
that referenced
this pull request
Feb 7, 2023
mist-api-connector: fix handling of TSSRT CONN_CLOSED events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.