Re-use Manifest ID with local B to avoid creating new sessions #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomshutt
commented
Oct 31, 2022
| @@ -61,19 +61,16 @@ type EncodedProfile struct { | |||
| ChromaFormat int32 `json:"chromaFormat,omitempty"` | |||
| } | |||
|
|
|||
| var client = &http.Client{ | |||
There was a problem hiding this comment.
Did some testing and didn't see any negative performance impact from reusing the HTTP client and Transport.
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
===================================================
+ Coverage 38.98635% 39.71261% +0.72626%
===================================================
Files 24 24
Lines 1539 1531 -8
===================================================
+ Hits 600 608 +8
+ Misses 861 844 -17
- Partials 78 79 +1
Continue to review full report at Codecov.
|
emranemran
approved these changes
Oct 31, 2022
iameli
pushed a commit
that referenced
this pull request
Feb 7, 2023
#121) * mapic: Store pushed bytes/minutes on pushInfo object * mapic: Store pushed time as duration * mapic: Accumulate prometheus metrics for multistream * mapic: Only save pushed time/bytes if increasing * metrics: Reorder multistream metrics * mapic: Init multistream metrics on stats collector * metrics: Fix view description
iameli
pushed a commit
that referenced
this pull request
Feb 7, 2023
Co-authored-by: livepeer-docker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of a fix for #113
We were seeing very slow transcode times and lots of logs where the B was struggling to find an O because we were passing in a blank manifestID and so it
was creating a new session for each segment.