Output rendition with dimensions == source #125
Conversation
| Bitrate int32 `json:"bitrate,omitempty"` | ||
| FPS uint `json:"fps,omitempty"` | ||
| FPSDen uint `json:"fpsDen,omitempty"` | ||
| Width int64 `json:"width,omitempty"` |
There was a problem hiding this comment.
We were using different types in different structs, so standardised on int64 / float64
There was a problem hiding this comment.
Go is much better than c++ when handling int and uint arithmetic !
| @@ -89,7 +89,7 @@ func TestRecordingCompleted(t *testing.T) { | |||
| require.NotNil(t, message.Success) | |||
| require.True(t, *message.Success) | |||
| require.GreaterOrEqual(t, message.Timestamp, testStartTime) | |||
| require.Less(t, message.Timestamp, testStartTime+2) | |||
| require.Less(t, message.Timestamp, testStartTime+100) | |||
There was a problem hiding this comment.
Nothing changed here, but the timing was a bit too tight on CI and so I was seeing some failures
thomshutt
requested review from
AlexKordic and
emranemran
and removed request for
AlexKordic
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
===================================================
+ Coverage 39.71261% 40.41052% +0.69791%
===================================================
Files 24 24
Lines 1531 1559 +28
===================================================
+ Hits 608 630 +22
- Misses 844 850 +6
Partials 79 79
Continue to review full report at Codecov.
|
| Name: "360p", | ||
| MediaData: []byte("pretend media data"), | ||
| }, | ||
| { | ||
| Name: "super-high-def", | ||
| Name: "720p", |
There was a problem hiding this comment.
Just a note for real broadcaster: name must start with letter otherwise transcode fails
There was a problem hiding this comment.
I didn't realise, good to know thanks!
This resolves #124