Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create dtsh headers at the end of transcoding phase #137

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

AlexKordic
Copy link
Contributor

Return manifest locations from RunTranscodeProcess() to create dtsh headers

Fixes #114

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #137 (237092a) into main (d38bab6) will decrease coverage by 0.30007%.
The diff coverage is 50.00000%.

❗ Current head 237092a differs from pull request most recent head 1e69a55. Consider uploading reports for the commit 1e69a55 to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #137         +/-   ##
===================================================
- Coverage   42.74438%   42.44431%   -0.30007%     
===================================================
  Files             26          26                 
  Lines           1647        1661         +14     
===================================================
+ Hits             704         705          +1     
- Misses           862         874         +12     
- Partials          81          82          +1     
Impacted Files Coverage Δ
handlers/misttriggers/push_end.go 50.79365% <ø> (-4.08440%) ⬇️
transcode/manifest.go 71.71717% <42.85714%> (-2.47638%) ⬇️
handlers/misttriggers/recording_end.go 25.15723% <44.82759%> (+4.54654%) ⬆️
transcode/transcode.go 66.66667% <100.00000%> (-0.18726%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38bab6...1e69a55. Read the comment docs.

Impacted Files Coverage Δ
handlers/misttriggers/push_end.go 50.79365% <ø> (-4.08440%) ⬇️
transcode/manifest.go 71.71717% <42.85714%> (-2.47638%) ⬇️
handlers/misttriggers/recording_end.go 25.15723% <44.82759%> (+4.54654%) ⬆️
transcode/transcode.go 66.66667% <100.00000%> (-0.18726%) ⬇️

}
url.RawQuery = ""
url.Fragment = ""
headerPrepare := exec.Command(path.Join(config.PathMistDir, "MistInHLS"), "-H", url.String())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do -g 5 to get more logs for helping in debug?

@AlexKordic AlexKordic merged commit 6c6cc79 into main Nov 3, 2022
@hjpotter92 hjpotter92 deleted the ak/dtsh_creation branch May 30, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger Mist DTSH file creation for all renditions
2 participants