Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transcode: Improve asset transcoded profiles #146

Merged
merged 7 commits into from
Nov 4, 2022
Merged

transcode: Improve asset transcoded profiles #146

merged 7 commits into from
Nov 4, 2022

Conversation

victorges
Copy link
Member

This is to make some improvements to the asset profile generation logic, leveraging
from the existing logic in task-runner today.

Main changes:

  • There's a longer list of default profiles, but those are filtered out depending on the source video
  • With that, changed the logic on including the source profile in the output. It's always added now (since there will be no profile equal or better than it from the above process)

@victorges
transcode: Avoid changing FPS of video
92ee141 
Just set it as 0 to maintain source FPS
@victorges
transcode: Avoid mutating shared variable
ae81e47
@victorges
transcode: Increase list of default profiles
1c644d5
@victorges
transcode: Create getPlaybackProfiles func
361da4a 
Copied and adapted from task-runner logic
@victorges
transcode: Move source profile logic to getPlaybackProfiles
e0f98a8 
Also always add the source profile. We already skip adding profiles
in a better quality than source.
thomshutt
thomshutt approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@thomshutt thomshutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks Victor!

@victorges victorges merged commit 5c9fcdb into main Nov 4, 2022
@victorges victorges deleted the vg/fix/transcode-renditions branch November 4, 2022 18:16
iameli pushed a commit that referenced this pull request Feb 7, 2023
@dependabot
build(deps): bump github.com/ProtonMail/gopenpgp/v2 from 2.4.5 to 2.4…
ff83922 
….10 (#146)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomshutt thomshutt thomshutt approved these changes

@emranemran emranemran Awaiting requested review from emranemran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorges @thomshutt