Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly report StreamInfo errors #156

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Correctly report StreamInfo errors #156

merged 2 commits into from
Nov 8, 2022

Conversation

thomshutt
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #156 (ccefab0) into main (21e952e) will decrease coverage by 0.02380%.
The diff coverage is 27.27273%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #156         +/-   ##
===================================================
- Coverage   42.57075%   42.54695%   -0.02380%     
===================================================
  Files             24          24                 
  Lines           1696        1704          +8     
===================================================
+ Hits             722         725          +3     
- Misses           883         887          +4     
- Partials          91          92          +1     
Impacted Files Coverage Δ
handlers/misttriggers/recording_end.go 24.09639% <0.00000%> (-0.29385%) ⬇️
clients/mist_client.go 50.21277% <50.00000%> (-0.00557%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e952e...ccefab0. Read the comment docs.

Impacted Files Coverage Δ
handlers/misttriggers/recording_end.go 24.09639% <0.00000%> (-0.29385%) ⬇️
clients/mist_client.go 50.21277% <50.00000%> (-0.00557%) ⬇️

@thomshutt thomshutt changed the title Correctly report StreamInfo errors and ignore 'booting' ones Correctly report StreamInfo errors Nov 8, 2022
@thomshutt thomshutt merged commit dfbcf6f into main Nov 8, 2022
@thomshutt thomshutt deleted the booting-error branch November 8, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants