transcode: update profile name for rendition that matches the source stream's resolution #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stream's resolution Remote B (via access-token) rejects transcode request if a profile with name "source" is used. The "source" keyword is used to define an incoming RTMP push in go-livepeer (server/mediaserver.go) - which triggers a different use-case. Change the profile name to follow the name syntax (e.g. 720p) being used for the other profiles.
emranemran
force-pushed
the
emran/fix-remote-b-transcode
branch
from
9dcf29c
to
e72e27d
Compare
emranemran
requested review from
thomshutt,
AlexKordic and
victorges
and removed request for
thomshutt and
AlexKordic
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
=============================================
Coverage 42.57075% 42.57075%
=============================================
Files 24 24
Lines 1696 1696
=============================================
Hits 722 722
Misses 883 883
Partials 91 91
Continue to review full report at Codecov.
|
emranemran
force-pushed
the
emran/fix-remote-b-transcode
branch
from
83be991
to
0e7b9f1
Compare
* transcode: use nicer names for rendition folders Instead of rendition-* folder names, use the profile name (e.g. 720p, 1080p, etc) as the folder name to make it more user friendly. * transcode: fix failing tests
thomshutt
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote B (via access-token) rejects transcode request if a profile with name "source" is used. The "source" keyword is used to define an incoming RTMP push in go-livepeer (server/mediaserver.go) - which triggers a different use-case. Change the profile name to follow the name syntax (e.g. 720p) being used for the other profiles.