Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcode completion % should reflect that there's now a DTSH generation stage after transcoding #164

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

thomshutt
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #164 (4fe313e) into main (7fc95eb) will increase coverage by 0.06731%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #164         +/-   ##
===================================================
+ Coverage   42.68078%   42.74809%   +0.06731%     
===================================================
  Files             24          24                 
  Lines           1701        1703          +2     
===================================================
+ Hits             726         728          +2     
  Misses           884         884                 
  Partials          91          91                 
Impacted Files Coverage Δ
clients/callback_client.go 54.13534% <100.00000%> (+0.70023%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc95eb...4fe313e. Read the comment docs.

Impacted Files Coverage Δ
clients/callback_client.go 54.13534% <100.00000%> (+0.70023%) ⬆️

Copy link
Contributor

@AlexKordic AlexKordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomshutt thomshutt merged commit d997701 into main Nov 10, 2022
@thomshutt thomshutt deleted the end-transcoding-dtsh-percentage branch November 10, 2022 11:20
iameli pushed a commit that referenced this pull request Feb 7, 2023
* testers: Return error from StartSegmenting(R)

* segmenter: Close out chan and fix first error

* segmenter: Make all fatal logs well behaved errors

Also create startSegmentingLoop helper function to avoid some of the
boilerplate repetition.

* api-transcoder: Fix only segmenter user ignoring errors

* segmenter: Support more than 2 streams

It is just for logs anyway but still

* segmenter: Make sure to close intermediate files

Not something that should be affecting task-runner,
but I saw that and why not fix it.

* segmenter: Avoid dead go-routines in segmenter

Might fix task-runner memory as well

* segmenter: ctype -> codecType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants