Transcode completion % should reflect that there's now a DTSH generation stage after transcoding #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion stage after transcoding
Codecov Report
@@ Coverage Diff @@
## main #164 +/- ##
===================================================
+ Coverage 42.68078% 42.74809% +0.06731%
===================================================
Files 24 24
Lines 1701 1703 +2
===================================================
+ Hits 726 728 +2
Misses 884 884
Partials 91 91
Continue to review full report at Codecov.
|
iameli
pushed a commit
that referenced
this pull request
Feb 7, 2023
* testers: Return error from StartSegmenting(R) * segmenter: Close out chan and fix first error * segmenter: Make all fatal logs well behaved errors Also create startSegmentingLoop helper function to avoid some of the boilerplate repetition. * api-transcoder: Fix only segmenter user ignoring errors * segmenter: Support more than 2 streams It is just for logs anyway but still * segmenter: Make sure to close intermediate files Not something that should be affecting task-runner, but I saw that and why not fix it. * segmenter: Avoid dead go-routines in segmenter Might fix task-runner memory as well * segmenter: ctype -> codecType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.