Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arweave -> S3 copy #169

Merged
merged 6 commits into from
Nov 11, 2022
Merged

Arweave -> S3 copy #169

merged 6 commits into from
Nov 11, 2022

Conversation

thomshutt
Copy link
Contributor

Arweave doesn't support HTTP Range request, so Mist can't natively read from it.

This initial solution is to copy from Arweave to S3 and then send the S3 URL into Mist.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #169 (70c92ce) into main (b33427b) will decrease coverage by 0.11499%.
The diff coverage is 50.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #169         +/-   ##
===================================================
- Coverage   47.14754%   47.03255%   -0.11499%     
===================================================
  Files             22          23          +1     
  Lines           1525        1567         +42     
===================================================
+ Hits             719         737         +18     
- Misses           716         736         +20     
- Partials          90          94          +4     
Impacted Files Coverage Δ
handlers/upload.go 46.03175% <25.00000%> (-6.64682%) ⬇️
clients/arweave_s3.go 67.85714% <67.85714%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33427b...70c92ce. Read the comment docs.

Impacted Files Coverage Δ
handlers/upload.go 46.03175% <25.00000%> (-6.64682%) ⬇️
clients/arweave_s3.go 67.85714% <67.85714%> (ø)

@thomshutt thomshutt marked this pull request as ready for review November 11, 2022 00:34
@emranemran emranemran merged commit 3645ce5 into main Nov 11, 2022
@emranemran emranemran deleted the arweave-s3-copy branch November 11, 2022 01:51
iameli pushed a commit that referenced this pull request Feb 7, 2023
* fix: export task uses pending instead of waiting

* Add error message to import task test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants