Define new API endpoint + test #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomshutt Wondering about repeated requests. How would entire system detect duplicate transcode jobs? Duplicate transcode request can have different callback URL, then we should also call this URL on completion. |
thomshutt
reviewed
Aug 10, 2022
handlers/handlers.go
Outdated
|
|
||
| schema, err := gojsonschema.NewSchema(schemaLoader) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
Let's handle it a bit more gracefully
There was a problem hiding this comment.
I could move the error on program start and panic early.. let me see how
There was a problem hiding this comment.
Fixed please check this commit
thomshutt
reviewed
Aug 10, 2022
thomshutt
reviewed
Aug 10, 2022
thomshutt
reviewed
Aug 15, 2022
|
|
||
| func WriteHTTPBadBodySchema(where string, w http.ResponseWriter, errors []gojsonschema.ResultError) apiError { | ||
| sb := strings.Builder{} | ||
| sb.WriteString("Body validation error in ") |
There was a problem hiding this comment.
I don't see people use the String Builder very often in Go, normally stuff like this is done with a fmt.Sprintf
thomshutt
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/api/transcode/fileadded tofunc StartCatalystAPIRouter()gojsonschemato check input json.OKfor now and invoke callback.