Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass millisecond duration correctly to Broadcaster #171

Merged
merged 5 commits into from
Nov 11, 2022
Merged

Pass millisecond duration correctly to Broadcaster #171

merged 5 commits into from
Nov 11, 2022

Conversation

thomshutt
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 11, 2022 •
edited
Loading

Codecov Report

Merging #171 (db70a19) into main (b33427b) will not change coverage.
The diff coverage is 100.00000%.

Impacted file tree graph

@@              Coverage Diff              @@
##                main        #171   +/-   ##
=============================================
  Coverage   47.14754%   47.14754%           
=============================================
  Files             22          22           
  Lines           1525        1525           
=============================================
  Hits             719         719           
  Misses           716         716           
  Partials          90          90
Impacted Files Coverage Δ
transcode/manifest.go 71.55963% <100.00000%> (ø)
transcode/transcode.go 66.83673% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33427b...db70a19. Read the comment docs.

Impacted Files Coverage Δ
transcode/manifest.go 71.55963% <100.00000%> (ø)
transcode/transcode.go 66.83673% <100.00000%> (ø)

yondonfu
yondonfu approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 nits - feel free to choose to address before merge.

LGTM

transcode/manifest.go Show resolved Hide resolved
transcode/transcode.go Show resolved Hide resolved
@thomshutt thomshutt merged commit 182412c into main Nov 11, 2022
@thomshutt thomshutt deleted the pass-millis-correctly branch November 11, 2022 15:49
iameli pushed a commit that referenced this pull request Feb 7, 2023
@ya7ya
Merge pull request #171 from livepeer/tq/fix_e2e_testing_running_export
a9fc9c2 
task-runner: exclude running and waiting status from export task error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emranemran emranemran emranemran approved these changes

@yondonfu yondonfu yondonfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomshutt @emranemran @yondonfu