Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constant backoff for DownloadOSURL #210

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Use constant backoff for DownloadOSURL #210

merged 3 commits into from
Nov 24, 2022

Conversation

red-0ne
Copy link
Contributor

@red-0ne red-0ne commented Nov 22, 2022

Implement a constant backoff with 1 second interval and 15 retries for osclient.DownloadOSURL

Closes #209

@red-0ne red-0ne self-assigned this Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #210 (404f085) into main (5dde9a5) will increase coverage by 0.05023%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #210         +/-   ##
===================================================
+ Coverage   51.15800%   51.20823%   +0.05023%     
===================================================
  Files             29          29                 
  Lines           1943        1945          +2     
===================================================
+ Hits             994         996          +2     
  Misses           842         842                 
  Partials         107         107                 
Impacted Files Coverage Δ
clients/object_store_client.go 87.50000% <100.00000%> (+0.35714%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dde9a5...404f085. Read the comment docs.

Impacted Files Coverage Δ
clients/object_store_client.go 87.50000% <100.00000%> (+0.35714%) ⬆️

Copy link
Contributor

@thomshutt thomshutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the couple of minor tweaks I've proposed

clients/object_store_client_test.go Outdated Show resolved Hide resolved
clients/object_store_client.go Outdated Show resolved Hide resolved
@thomshutt
Copy link
Contributor

Also, let's remove that hacky 5 second wait that I put in now that we have a better solution!

@red-0ne red-0ne closed this Nov 24, 2022
@red-0ne red-0ne reopened this Nov 24, 2022
@red-0ne red-0ne merged commit 7ed2f28 into main Nov 24, 2022
@hjpotter92 hjpotter92 deleted the constant-retry-time branch May 30, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a constant retry time for DownloadOSURL
2 participants