-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use constant backoff for DownloadOSURL #210
Conversation
Codecov Report
@@ Coverage Diff @@
## main #210 +/- ##
===================================================
+ Coverage 51.15800% 51.20823% +0.05023%
===================================================
Files 29 29
Lines 1943 1945 +2
===================================================
+ Hits 994 996 +2
Misses 842 842
Partials 107 107
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the couple of minor tweaks I've proposed
Also, let's remove that hacky 5 second wait that I put in now that we have a better solution! |
18990e8
to
87912aa
Compare
Implement a constant backoff with 1 second interval and 15 retries for osclient.DownloadOSURL
Closes #209