Return an HTTP 429 when we're over capacity #232
Conversation
Codecov Report
@@ Coverage Diff @@
## main #232 +/- ##
===================================================
+ Coverage 51.85364% 52.07156% +0.21792%
===================================================
Files 32 33 +1
Lines 2077 2124 +47
===================================================
+ Hits 1077 1106 +29
- Misses 894 912 +18
Partials 106 106
Continue to review full report at Codecov.
|
| coordinator.StartUploadJob(pipeline.UploadJobPayload{ | ||
| RequestID: fmt.Sprintf("request-%d", x), | ||
| }) | ||
| } | ||
|
|
||
| // Set up the HTTP handler | ||
| handler := HasCapacity(coordinator, next) |
There was a problem hiding this comment.
Hmm I wonder how racy this is since the jobs run in background and the stub handlers return immediately. Does it pass consistently?
There was a problem hiding this comment.
Yep, I think because the stub handlers never trigger the Mist callbacks right? So the jobs stay in flight
There was a problem hiding this comment.
Not sure actually. I think they may return an error which finishes the job and sends a callback
There was a problem hiding this comment.
it's the real handlers with mock clients instead
Currently very crude, but protects us from being DOSed.
Future iterations will probably be