Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse Mist auth response correctly #25

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Parse Mist auth response correctly #25

merged 1 commit into from
Aug 15, 2022

Conversation

thomshutt
Copy link
Contributor

@thomshutt thomshutt commented Aug 15, 2022 •
edited
Loading

This was failing because one of the fields isn't a string but we were trying to parse it as one.

Switched to only parsing the field we care about, which should be safer if other fields appear here in the future.

{
  "local": true,
  "status": "OK"
}

@thomshutt thomshutt merged commit aec5ca9 into main Aug 15, 2022
@thomshutt thomshutt deleted the handle-mist-auth-response branch August 15, 2022 13:45
@thomshutt thomshutt mentioned this pull request Aug 15, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-0ne red-0ne red-0ne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomshutt @red-0ne