Switch to HTTP retry library #26
Conversation
| type CallbackClient struct { | ||
| httpClient *http.Client | ||
| httpClient *retryablehttp.Client |
There was a problem hiding this comment.
WDYT of keeping this as a regular http.Client, just so we can switch from the retry lib more seamlessly?
There was a problem hiding this comment.
http.Client isn't an interface though, how would we switch between the two?
There was a problem hiding this comment.
There's apparently a function in the retry client to return a corresponding http.Client! I saw it mentioned in the end of their readme I think
There was a problem hiding this comment.
Huh nice, I had seen that but had missed that it includes the retry functionality
StandardClient returns a stdlib *http.Client with a custom Transport, which shims in a *retryablehttp.Client for added retries.
Will make a new PR for that
clients/callback_client.go
Outdated
| func (c CallbackClient) DoWithRetries(r *retryablehttp.Request) error { | ||
| resp, err := c.httpClient.Do(r) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to send callback to %q. Error: %s", r.URL.String(), err) | ||
| } | ||
|
|
||
| if err != nil { | ||
| return fmt.Errorf("failed to send callback to %q. Error: %q", r.URL.String(), err) | ||
| if resp.StatusCode >= 400 { | ||
| return fmt.Errorf("failed to send callback to %q. HTTP Code: %d", r.URL.String(), resp.StatusCode) | ||
| } | ||
| return fmt.Errorf("failed to send callback to %q. Response Status Code: %d", r.URL.String(), resp.StatusCode) | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
Is this still necessary? I think it could be replaced by a simpler helper like responseToError(res *http.Response) error
There was a problem hiding this comment.
Not sure I 100% understand where the helper would sit, but we do still need the StatusCode check since the retry library only errors on >= 500
Co-authored-by: Victor Elias <[email protected]>
We were getting errors because of not resetting the POST body correctly before retrying, so decided to switch to a library and not have to think about that stuff.