Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document local integration testing / development #29

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Conversation

thomshutt
Copy link
Contributor

No description provided.

@@ -53,7 +53,7 @@ func StartCatalystAPIRouter(mc *handlers.MistClient) *httprouter.Router {
catalystApiHandlers := &handlers.CatalystAPIHandlersCollection{MistClient: mc, StreamCache: sc}
mistCallbackHandlers := &handlers.MistCallbackHandlersCollection{MistClient: mc, StreamCache: sc}

router.GET("/ok", withLogging(middleware.IsAuthorized(catalystApiHandlers.Ok())))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the auth on this endpoint to make it simpler to use as a sanity check of if things are running

Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, I guess we need to bundle it inside the livepeer/catalyst and remove these instructions. Is that correct?

@thomshutt
Copy link
Contributor Author

In the future, I guess we need to bundle it inside the livepeer/catalyst and remove these instructions. Is that correct?

I don't think so, unless we want to move to a monorepo type setup

@thomshutt thomshutt merged commit 28a93dd into main Aug 18, 2022
@thomshutt thomshutt deleted the local-dev-doc branch August 18, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants