Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Switch from 2 pass -> 1 pass encoding" #295

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Revert "Switch from 2 pass -> 1 pass encoding" #295

merged 1 commit into from
Dec 12, 2022

Conversation

thomshutt
Copy link
Contributor

Reverts #287

yondonfu
yondonfu approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #295 (3d14b90) into main (1463bee) will not change coverage.
The diff coverage is 0.00000%.

Impacted file tree graph

@@              Coverage Diff              @@
##                main        #295   +/-   ##
=============================================
  Coverage   44.81394%   44.81394%           
=============================================
  Files             35          35           
  Lines           2526        2526           
=============================================
  Hits            1132        1132           
  Misses          1288        1288           
  Partials         106         106
Impacted Files Coverage Δ
clients/mediaconvert.go 0.00000% <0.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1463bee...3d14b90. Read the comment docs.

Impacted Files Coverage Δ
clients/mediaconvert.go 0.00000% <0.00000%> (ø)

@thomshutt thomshutt merged commit 2143134 into main Dec 12, 2022
@thomshutt thomshutt deleted the revert-287-thom/single-pass branch December 12, 2022 17:01
iameli pushed a commit that referenced this pull request Feb 7, 2023
@github-actions @livepeer-docker
[AUTO-COMMIT] Update manifest.yaml (#295)
661d9c9 
Files changed:
M	manifest.yaml

Co-authored-by: livepeer-docker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yondonfu yondonfu yondonfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomshutt @yondonfu