-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out HTTP + Handlers #36
Conversation
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
===================================================
- Coverage 44.72441% 44.42675% -0.29767%
===================================================
Files 8 12 +4
Lines 635 628 -7
===================================================
- Hits 284 279 -5
+ Misses 314 312 -2
Partials 37 37
Continue to review full report at Codecov.
|
LGTM - didn't find any issues with the logic but we can address after everything is merged and tested. |
We're going to deprecate the giant PR in #30 and try to split it into a series of more manageable / reviewable ones.
This one creates a more manageable base in terms of package structure by only doing CLI stuff in the
cmd
package and moving HTTP layer functions intoapi
. It also splits outhandlers/handlers.go
into different files based on functionality - e.ghandlers/upload.go
. It also moves the Mist client into theclients
package.