Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple PUSH_END causes #39

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

thomshutt
Copy link
Contributor

This also brings in the creation of a StreamCache wrapper object from #30

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #39 (3248607) into main (1c3a78e) will increase coverage by 10.01717%.
The diff coverage is 72.00000%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##                main         #39          +/-   ##
====================================================
+ Coverage   42.65842%   52.67559%   +10.01717%     
====================================================
  Files             12          13           +1     
  Lines            647         598          -49     
====================================================
+ Hits             276         315          +39     
+ Misses           332         244          -88     
  Partials          39          39                  
Impacted Files Coverage Δ
clients/callback_client.go 63.06306% <ø> (ø)
handlers/transcode.go 44.44444% <0.00000%> (ø)
cache/transcoding.go 45.71429% <45.71429%> (ø)
handlers/upload.go 51.28205% <91.66667%> (+6.35450%) ⬆️
api/http.go 55.88235% <100.00000%> (-1.26051%) ⬇️
cache/segmenting.go 100.00000% <100.00000%> (ø)
cache/stream.go 100.00000% <100.00000%> (ø)
handlers/misttriggers/triggers.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3a78e...3248607. Read the comment docs.

Impacted Files Coverage Δ
clients/callback_client.go 63.06306% <ø> (ø)
handlers/transcode.go 44.44444% <0.00000%> (ø)
cache/transcoding.go 45.71429% <45.71429%> (ø)
handlers/upload.go 51.28205% <91.66667%> (+6.35450%) ⬆️
api/http.go 55.88235% <100.00000%> (-1.26051%) ⬇️
cache/segmenting.go 100.00000% <100.00000%> (ø)
cache/stream.go 100.00000% <100.00000%> (ø)
handlers/misttriggers/triggers.go

Base automatically changed from split-http-handlers-lint to main September 7, 2022 22:19
@emranemran emranemran merged commit 3f4614f into main Sep 8, 2022
@emranemran emranemran deleted the split-http-handlers-lint-make branch September 8, 2022 00:28
iameli added a commit that referenced this pull request Feb 7, 2023
add new simple Catalyst Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants