Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont set video track size #440

Merged
merged 1 commit into from
Feb 8, 2023
Merged

dont set video track size #440

merged 1 commit into from
Feb 8, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Feb 8, 2023

this was misleading as it is actually the total file size (video and audio) we were not using the field anywhere anyway

this was misleading as it is actually the total file size (video and audio) we were not using the field anywhere anyway
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #440 (5fd805e) into main (aa0aa76) will increase coverage by 0.01778%.
The diff coverage is 25.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #440         +/-   ##
===================================================
+ Coverage   55.68327%   55.70105%   +0.01778%     
===================================================
  Files             39          39                 
  Lines           3132        3131          -1     
===================================================
  Hits            1744        1744                 
+ Misses          1243        1242          -1     
  Partials         145         145                 
Impacted Files Coverage Δ
video/probe.go 0.00000% <0.00000%> (ø)
clients/mediaconvert.go 71.99074% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0aa76...5fd805e. Read the comment docs.

Impacted Files Coverage Δ
video/probe.go 0.00000% <0.00000%> (ø)
clients/mediaconvert.go 71.99074% <100.00000%> (ø)

@mjh1 mjh1 merged commit 59c9744 into main Feb 8, 2023
@mjh1 mjh1 deleted the mh/cleanup branch February 8, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants