Increase the timeout for mediaconvert to support big mp4 files #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
=============================================
Coverage 55.36547% 55.36547%
=============================================
Files 40 40
Lines 3215 3215
=============================================
Hits 1780 1780
Misses 1288 1288
Partials 147 147
Continue to review full report at Codecov.
|
victorges
approved these changes
Feb 16, 2023
clients/mediaconvert.go
Outdated
| @@ -481,7 +481,7 @@ func copyFile(ctx context.Context, sourceURL, destOSBaseURL, filename, requestID | |||
|
|
|||
| content := io.TeeReader(c, &writtenBytes) | |||
|
|
|||
| err = UploadToOSURL(destOSBaseURL, filename, content, 5*time.Minute) | |||
| err = UploadToOSURL(destOSBaseURL, filename, content, 30*time.Minute) | |||
There was a problem hiding this comment.
Would be good to have a const for this (my bad)
leszko
force-pushed
the
rafal/increase-mediaconvert-timeout
branch
from
0cb358f
to
e082de2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we start supporting mp4 output, then the current timeout for saving data (
5 min) may not be high enough. This PR increases this timeout.However, I think we could think about an approach in which the timeout actually depends on the file size. @emranemran @victorges wdyt?
Also a comment from @emranemran