Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move copy functions to input_copy #467

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Move copy functions to input_copy #467

merged 1 commit into from
Feb 16, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Feb 16, 2023

Moving copy functions to input_copy.go as they'll now be used for the mist pipeline too.

@mjh1 mjh1 requested a review from thomshutt February 16, 2023 13:00
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #467 (403c156) into main (623cadd) will not change coverage.
The diff coverage is 60.46512%.

Impacted file tree graph

@@              Coverage Diff              @@
##                main        #467   +/-   ##
=============================================
  Coverage   55.36547%   55.36547%           
=============================================
  Files             40          40           
  Lines           3215        3215           
=============================================
  Hits            1780        1780           
  Misses          1288        1288           
  Partials         147         147           
Impacted Files Coverage Δ
clients/mediaconvert.go 71.01064% <ø> (+1.08224%) ⬆️
clients/input_copy.go 58.62069% <60.46512%> (+1.80251%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 623cadd...403c156. Read the comment docs.

Impacted Files Coverage Δ
clients/mediaconvert.go 71.01064% <ø> (+1.08224%) ⬆️
clients/input_copy.go 58.62069% <60.46512%> (+1.80251%) ⬆️

Copy link
Contributor

@thomshutt thomshutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add a description about why you're moving this please

@mjh1 mjh1 merged commit 8b4f260 into main Feb 16, 2023
@mjh1 mjh1 deleted the mh/move-funcs branch February 16, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants