Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording start callback #49

Merged
merged 7 commits into from
Sep 30, 2022
Merged

Recording start callback #49

merged 7 commits into from
Sep 30, 2022

Conversation

AlexKordic
Copy link
Contributor

No description provided.

Triggers: Use switch to branch to proper pipeline logic based on stream name
Move string constant from UploadVOD() to config
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #49 (9f401ee) into main (2e7f91d) will increase coverage by 1.09767%.
The diff coverage is 44.89796%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #49         +/-   ##
===================================================
+ Coverage   32.07354%   33.17121%   +1.09767%     
===================================================
  Files             16          17          +1     
  Lines            979        1028         +49     
===================================================
+ Hits             314         341         +27     
- Misses           628         646         +18     
- Partials          37          41          +4     
Impacted Files Coverage Δ
clients/callback_client.go 56.00000% <0.00000%> (-7.06307%) ⬇️
handlers/misttriggers/push_out_start.go 60.60606% <60.60606%> (ø)
handlers/misttriggers/triggers.go 17.34694% <100.00000%> (+6.93027%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7f91d...9f401ee. Read the comment docs.

Impacted Files Coverage Δ
clients/callback_client.go 56.00000% <0.00000%> (-7.06307%) ⬇️
handlers/misttriggers/push_out_start.go 60.60606% <60.60606%> (ø)
handlers/misttriggers/triggers.go 17.34694% <100.00000%> (+6.93027%) ⬆️

@AlexKordic AlexKordic marked this pull request as ready for review September 26, 2022 20:52
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

clients/callback_client.go Show resolved Hide resolved
clients/callback_client.go Outdated Show resolved Hide resolved
clients/callback_client.go Outdated Show resolved Hide resolved
clients/callback_client.go Outdated Show resolved Hide resolved
log.Printf("RecordingPushOutStart addUuidToUrl() %v", err)
return destination
}
go clients.DefaultCallbackClient.SendRecordingEvent(event)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should make these hooks blocking instead. As in if they fail we should not let the stream go through either. Only opening for consideration tho, not sure what i prefer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good practice is to return as soon as possible so mistserver can continue without additional latency increase.

Lets consider a watchdog process that kills bad streams separately from our happy-path.

handlers/misttriggers/push_out_start.go Outdated Show resolved Hide resolved
handlers/misttriggers/push_out_start.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@AlexKordic AlexKordic changed the base branch from ak/pipeline_definitions to main September 30, 2022 04:56
@AlexKordic AlexKordic merged commit e38280c into main Sep 30, 2022
@hjpotter92 hjpotter92 deleted the ak/uuid_generation branch May 30, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants