Fix data race #492
Merged
Fix data race #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were seeing intermittent data race failures in our unit tests. This backoff implementation is advertised as not thread safe so we need a new instance each time. https://github.com/cenkalti/backoff/blob/v4.2.0/tries.go#L10-L12
|
Damn, just noticed there are a few more occurrences that need fixing too. |
Codecov Report
@@ Coverage Diff @@
## main #492 +/- ##
===================================================
- Coverage 55.41085% 55.04615% -0.36470%
===================================================
Files 40 40
Lines 3225 3250 +25
===================================================
+ Hits 1787 1789 +2
- Misses 1293 1324 +31
+ Partials 145 137 -8
Continue to review full report at Codecov.
|
|
Ok fixed all of them now 👍 |
emranemran
approved these changes
Feb 28, 2023
clients/input_copy.go
Outdated
| @@ -155,3 +153,7 @@ type StubInputCopy struct{} | |||
| func (s *StubInputCopy) CopyInputToS3(requestID string, inputFile, osTransferURL *url.URL) (inputVideoProbe video.InputVideo, signedURL string, err error) { | |||
| return video.InputVideo{}, "", nil | |||
| } | |||
|
|
|||
| func RetryBackoff() backoff.BackOff { | |||
| return backoff.WithMaxRetries(newExponentialBackOffExecutor(), 5) | |||
There was a problem hiding this comment.
Maybe better to create two functions for better readability?
func RetryExponentialBackoff() and func RetryConstantBackoff()
thomshutt
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing intermittent data race failures in our unit tests. This backoff implementation is advertised as not thread safe so we need a new instance each time. https://github.com/cenkalti/backoff/blob/v4.2.0/tries.go#L10-L12