config: MistProcLivepeer in /usr/local/bin/ #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emranemran
approved these changes
Sep 29, 2022
hjpotter92
reviewed
Oct 3, 2022
| @@ -12,7 +12,7 @@ var Version string | |||
| var Clock TimestampGenerator = RealTimestampGenerator{} | |||
|
|
|||
| // Path to Mist's "Livepeer" process that we shell out to for the transcoding | |||
| const PathMistProcLivepeer = "/usr/bin/MistProcLivepeer" | |||
| const PathMistProcLivepeer = "/usr/local/bin/MistProcLivepeer" | |||
There was a problem hiding this comment.
is it necessary to hardcode the full path to binary? wouldn't go be able to exec them from $PATH value?
There was a problem hiding this comment.
If we can simplify this so that Go can exec MistProcLivepeer from $PATH instead of hardcoding a path here (which resulted in issues previously when the path that MistProcLivepeer was at changed), then that seems like a worthwhile improvement. @hjpotter92 mind tracking this is in an issue so this can be addressed?
There was a problem hiding this comment.
Actually looks like this is tracked here livepeer/catalyst#172
iameli
pushed a commit
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See livepeer/catalyst@83d3bcd
MistProcLivepeer needs to be invoked in /usr/local/bin after the above commit that changes where MistController is invoked from.