Begin transcode right after PUSH_END trigger #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segmentation is completed: * generate transcodeRequest in SegmentingPushEnd handler (since transcodeRequest will not be generated from the HTTP API endpoint) * update Segmenting cache Store function to store additional fields which will be used in transcodeRequest above
victorges
reviewed
Oct 6, 2022
handlers/misttriggers/push_end.go
Outdated
| SourceFile: si.SourceFile, | ||
| CallbackUrl: si.CallbackUrl, | ||
| } | ||
| go handlers.RunTranscodeProcess(d.MistClient, transcodeRequest) |
There was a problem hiding this comment.
Cool! I think for the /vod API behavior, you might want to wrap this into a local helper which handles the results sending the appropriate callbacks to Studio etc. I guess that's somewhat what you've done on your local change that you mentioned tho?
Btw does this StreamInfo have the "probing" information of the file? If so, should be really easy to generate the profiles copying that logic from task-runner
emranemran
force-pushed
the
emran/async-transcode
branch
from
3377855
to
67f9273
Compare
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
===================================================
- Coverage 36.42447% 35.17364% -1.25084%
===================================================
Files 17 17
Lines 1046 1123 +77
===================================================
+ Hits 381 395 +14
- Misses 618 681 +63
Partials 47 47
Continue to review full report at Codecov.
|
thomshutt
approved these changes
Oct 10, 2022
|
Woohoo nice
…On Mon, 10 Oct 2022, 09:50 Thom Shutt, ***@***.***> wrote:
Merged #54 <#54> into main.
—
Reply to this email directly, view it on GitHub
<#54 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMJ4R3A4O6DD2MTKM6VHV3WCQGLDANCNFSM6AAAAAAQ6IEYW4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin transcode right after PUSH_END trigger is receieved after segmentation is completed: