Dont send videos with rotation to mist #553
Conversation
Codecov Report
@@ Coverage Diff @@
## main #553 +/- ##
===================================================
+ Coverage 55.16202% 55.38615% +0.22413%
===================================================
Files 49 49
Lines 3981 4001 +20
===================================================
+ Hits 2196 2216 +20
Misses 1602 1602
Partials 183 183
Continue to review full report in Codecov by Sentry.
|
| @@ -291,39 +291,6 @@ func Test_MP4OutDurationCheck(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestProbe(t *testing.T) { | |||
There was a problem hiding this comment.
moved this to probe_test.go, it was missed in a previous refactor
go.mod
Outdated
| @@ -174,3 +174,5 @@ require ( | |||
| gopkg.in/yaml.v2 v2.4.0 // indirect | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| ) | |||
|
|
|||
| replace gopkg.in/vansante/go-ffprobe.v2 => github.com/mjh1/go-ffprobe v0.0.0-20230330150500-3b664b71952e | |||
There was a problem hiding this comment.
Did you raise a PR against the upstream repo?
There was a problem hiding this comment.
not yet as i was planning on expanding it to include all the different possible side data fields. but through a bit of searching it looks like there may be too much to include in named struct fields :( can't find a definitive list of all variations.
Found this typescript version: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/ffprobe/index.d.ts
But then chatgpt says there are way more options ha (each with their own set of associated fields):
So might have to be a map[string]interface{} kind of thing
There was a problem hiding this comment.
Yeah, that sounds like a good idea and then we can leave it to someone else to do the full list if needed
Rotation was found to be ignored by mist so this ensures we only send videos like that to mediaconvert