Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: populate undetected audio/video codecs as "n/a" #564

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

emranemran
Copy link
Collaborator

Several audio-less video is uploaded to livepeer. These jobs get recorded in the db as having a blank codec field which makes it tricky to parse stats. Explicitly set these job fields to "n/a" whenever a codec is missing for a given video/audio track.

Several audio-less video is uploaded to livepeer. These jobs get
recorded in the db as having a blank codec field which makes it tricky
to parse stats. Explicitly set these job fields to "n/a" whenever a
codec is missing for a given video/audio track.
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #564 (9de9300) into main (bf5f658) will increase coverage by 0.03921%.
The diff coverage is 80.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #564         +/-   ##
===================================================
+ Coverage   54.75883%   54.79804%   +0.03921%     
===================================================
  Files             48          48                 
  Lines           3877        3887         +10     
===================================================
+ Hits            2123        2130          +7     
- Misses          1584        1585          +1     
- Partials         170         172          +2     
Impacted Files Coverage Δ
pipeline/coordinator.go 80.71625% <80.00000%> (-0.30358%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5f658...9de9300. Read the comment docs.

Impacted Files Coverage Δ
pipeline/coordinator.go 80.71625% <80.00000%> (-0.30358%) ⬇️

@emranemran emranemran merged commit 5151a8f into main Apr 3, 2023
@emranemran emranemran deleted the emran/fix-codec-metrics branch April 3, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants