Add Manifest URL to output metadata #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
===================================================
+ Coverage 35.17364% 35.58719% +0.41355%
===================================================
Files 17 17
Lines 1123 1124 +1
===================================================
+ Hits 395 400 +5
+ Misses 681 677 -4
Partials 47 47
Continue to review full report at Codecov.
|
emranemran
approved these changes
Oct 11, 2022
| @@ -33,6 +33,11 @@ func (d *MistCallbackHandlersCollection) Trigger() httprouter.Handle { | |||
| } | |||
|
|
|||
| triggerName := req.Header.Get("X-Trigger") | |||
| _ = config.Logger.Log( | |||
| "msg", "Received Mist Trigger", | |||
There was a problem hiding this comment.
minor: should we log similarly when we ask mist to add PUSH destinations? Might give us a clue as to why we see 2x PUSH_END triggers firing. I'm suspecting we're inadvertently adding an extra PUSH somewhere.
There was a problem hiding this comment.
Good call, will add in a new PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.