Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auth token configurable (no longer hardcoded) #59

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

thomshutt
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #59 (b290c0e) into main (ee8a242) will decrease coverage by 0.15761%.
The diff coverage is 41.66667%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #59         +/-   ##
===================================================
- Coverage   35.58719%   35.42958%   -0.15761%     
===================================================
  Files             17          17                 
  Lines           1124        1129          +5     
===================================================
  Hits             400         400                 
- Misses           677         682          +5     
  Partials          47          47                 
Impacted Files Coverage Δ
clients/mist_client.go 44.82759% <0.00000%> (-0.98739%) ⬇️
api/http.go 54.28571% <60.00000%> (ø)
middleware/auth.go 93.33333% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4fe9ce...b290c0e. Read the comment docs.

Impacted Files Coverage Δ
clients/mist_client.go 44.82759% <0.00000%> (-0.98739%) ⬇️
api/http.go 54.28571% <60.00000%> (ø)
middleware/auth.go 93.33333% <100.00000%> (ø)

@thomshutt thomshutt merged commit 6666234 into main Oct 11, 2022
@thomshutt thomshutt deleted the config-auth branch October 11, 2022 11:22
iameli added a commit that referenced this pull request Feb 7, 2023
[BOT] Update `manifest.yaml` for staging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants