Upload transcodes to output target location rather than input location #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
===================================================
+ Coverage 35.42958% 35.48673% +0.05715%
===================================================
Files 17 17
Lines 1129 1130 +1
===================================================
+ Hits 400 401 +1
Misses 682 682
Partials 47 47
Continue to review full report at Codecov.
|
thomshutt
commented
Oct 13, 2022
| CallbackUrl string | ||
| UploadDir string | ||
| CallbackURL string | ||
| UploadURL string |
There was a problem hiding this comment.
Changed Url -> URL because that's Go convention.
Changed "Dir" to URL because it's a URL and not a Dir
emranemran
approved these changes
Oct 14, 2022
| @@ -36,6 +36,7 @@ func (d *MistCallbackHandlersCollection) Trigger() httprouter.Handle { | |||
| _ = config.Logger.Log( | |||
| "msg", "Received Mist Trigger", | |||
| "trigger_name", triggerName, | |||
| "payload", string(payload), | |||
hjpotter92
reviewed
Oct 14, 2022
| @@ -107,11 +100,11 @@ func RunTranscodeProcess(mistClient clients.MistAPIClient, request TranscodeSegm | |||
| return fmt.Errorf("failed to start MistProcLivepeer: %s", err) | |||
| } | |||
|
|
|||
| dir, _ := url.Parse(".") | |||
| uploadDir := inputUrl.ResolveReference(dir) | |||
| dir, _ := url.Parse("transcoded/") | |||
There was a problem hiding this comment.
does it need to be hard-coded or can it be configurable in request payload?
There was a problem hiding this comment.
At least initially, hardcoded - can look at making it variable in the future if needed
iameli
added a commit
that referenced
this pull request
Feb 7, 2023
* Add playback redirection to the closest Mist node * Update for `http-addr` flag and Mist Load Balancer 'video+' prefix * Add E2E test for stream redirection * Remove unused params in E2E Test * Update cmd/catalyst-node/catalyst-node.go Co-authored-by: Eli Mallon <[email protected]> * Update cmd/catalyst-node/catalyst-node.go Co-authored-by: Eli Mallon <[email protected]> * Update cmd/catalyst-node/catalyst-node_test.go Co-authored-by: Eli Mallon <[email protected]> * Update cmd/catalyst-node/catalyst-node.go Co-authored-by: Eli Mallon <[email protected]> * Minor fixes after code review * Handle Mist returning "FULL" from LoadBalancer API * go fmt * Fix Revive warnings * Fix CI builds Co-authored-by: Eli Mallon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts all transcoded segments + manifests under a
transcoded/dir, rather than alongside the source MP4.Doesn't account for multiple output locations yet, but is enough for us to test with.