Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handlers: use last 10 log lines to determine successful push #71

Merged
merged 1 commit into from
Oct 19, 2022
Merged

handlers: use last 10 log lines to determine successful push #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions handlers/misttriggers/push_end.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,8 @@ func (d *MistCallbackHandlersCollection) SegmentingPushEnd(w http.ResponseWriter
return
}

// If PushStatus is null, push has failed
if p.PushStatus == "null" {
// TODO: Find a better way to determine if the push status was successfull (i.e. segmenting step was successful)
if !strings.Contains(p.Last10LogLines, "Buffer completely played out") {
_ = clients.DefaultCallbackClient.SendTranscodeStatusError(callbackUrl, "Segmenting Failed: "+p.PushStatus)
_ = errors.WriteHTTPBadRequest(w, "Segmenting Failed. PUSH_END trigger for stream "+p.StreamName+" was "+p.PushStatus, nil)
return
Expand Down