handlers: force mp4 override for source URLs #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Studio is not expected to know the extension types of the files uploaded by the end user. As such, Studio can provide urls without any file extensions like mp4/mov. However, Mist requires file extensions to guess what type of input process to spawn (e.g. MistInMP4). For now, we only care about mp4/mov file input - so we force all input URLs to mp4 format by using the "mp4:" override in front of an URL identifier so the it reads: "mp4:s3+http://example-url.com/video"
victorges
approved these changes
Oct 19, 2022
| @@ -112,6 +112,8 @@ func (d *CatalystAPIHandlersCollection) UploadVOD() httprouter.Handle { | |||
| } | |||
|
|
|||
| func (d *CatalystAPIHandlersCollection) processUploadVOD(streamName, sourceURL, targetURL string) error { | |||
| // TODO: remove this logic to force input URLs to mp4/mov format | |||
| sourceURL = "mp4:" + sourceURL | |||
There was a problem hiding this comment.
Will mist handle mp4:https:// fine?
There was a problem hiding this comment.
Yep it discards mp4: and uses it to know that the source URL is an mp4/mov file
thomshutt
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Studio is not expected to know the extension types of the files uploaded by the end user. As such, Studio can provide urls without any file extensions like mp4/mov. However, Mist requires file extensions to guess what type of input process to spawn (e.g. MistInMP4).
For now, we only care about mp4/mov file input - so we force all input URLs to mp4 format by using the "mp4:" override in front of an URL identifier so the it reads: "mp4:s3+http://example-url.com/video"