-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache: print cache for easier debugging #76
Conversation
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
===================================================
+ Coverage 38.76543% 39.26531% +0.49988%
===================================================
Files 18 18
Lines 1215 1225 +10
===================================================
+ Hits 471 481 +10
Misses 688 688
Partials 56 56
Continue to review full report at Codecov.
|
cache/transcoding.go
Outdated
info.updatedAt = time.Now() | ||
c.pushes[streamName] = &info | ||
c.mutex.Unlock() | ||
c.Print() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely print information about what's happening (Storing to / removing from the cache) and I don't love this "Debug" flag. Let's just be bold and log it until we hit traffic levels where the logging volume is an issue
d0be73a
to
86806ee
Compare
Updates:
|
It's nice to see print the cache contents when things are stored/deleted from the cache - makes debugging certain situations easier.