Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcode in Catalyst API: Download and parse source manifest #87

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

thomshutt
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #87 (08f8644) into main (09d35c6) will increase coverage by 7.85099%.
The diff coverage is 92.30769%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #87         +/-   ##
===================================================
+ Coverage   38.92023%   46.77122%   +7.85099%     
===================================================
  Files             18          20          +2     
  Lines           1241        1084        -157     
===================================================
+ Hits             483         507         +24     
+ Misses           702         521        -181     
  Partials          56          56                 
Impacted Files Coverage Δ
handlers/misttriggers/push_end.go 56.96203% <ø> (+16.42149%) ⬆️
handlers/misttriggers/recording_end.go 27.27273% <0.00000%> (ø)
handlers/transcode.go 42.30769% <0.00000%> (+36.02198%) ⬆️
clients/object_store_client.go 100.00000% <100.00000%> (ø)
transcode/transcode.go 100.00000% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d35c6...08f8644. Read the comment docs.

Impacted Files Coverage Δ
handlers/misttriggers/push_end.go 56.96203% <ø> (+16.42149%) ⬆️
handlers/misttriggers/recording_end.go 27.27273% <0.00000%> (ø)
handlers/transcode.go 42.30769% <0.00000%> (+36.02198%) ⬆️
clients/object_store_client.go 100.00000% <100.00000%> (ø)
transcode/transcode.go 100.00000% <100.00000%> (ø)

Copy link
Contributor

@AlexKordic AlexKordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start

@thomshutt thomshutt merged commit 580f41a into main Oct 26, 2022
@thomshutt thomshutt deleted the transcode-in-go branch October 26, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants