Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Master + Rendition manifests #89

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Write Master + Rendition manifests #89

merged 1 commit into from
Oct 27, 2022

Conversation

thomshutt
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #89 (2e4d0fb) into main (6fa7738) will increase coverage by 0.79123%.
The diff coverage is 59.37500%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #89         +/-   ##
===================================================
+ Coverage   46.77996%   47.57119%   +0.79123%     
===================================================
  Files             21          21                 
  Lines           1118        1194         +76     
===================================================
+ Hits             523         568         +45     
- Misses           533         557         +24     
- Partials          62          69          +7     
Impacted Files Coverage Δ
clients/object_store_client.go 50.00000% <0.00000%> (-50.00000%) ⬇️
handlers/misttriggers/recording_end.go 27.27273% <0.00000%> (ø)
handlers/transcode.go 42.30769% <0.00000%> (ø)
transcode/transcode.go 46.42857% <60.00000%> (-3.57143%) ⬇️
transcode/manifest.go 72.09302% <68.91892%> (-2.90698%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa7738...2e4d0fb. Read the comment docs.

Impacted Files Coverage Δ
clients/object_store_client.go 50.00000% <0.00000%> (-50.00000%) ⬇️
handlers/misttriggers/recording_end.go 27.27273% <0.00000%> (ø)
handlers/transcode.go 42.30769% <0.00000%> (ø)
transcode/transcode.go 46.42857% <60.00000%> (-3.57143%) ⬇️
transcode/manifest.go 72.09302% <68.91892%> (-2.90698%) ⬇️

@emranemran
Copy link
Collaborator

Just one comment that can be addressed in follow-up if needed but otherwise LGTM.


for i, profile := range transcodeProfiles {
// For each profile, add a new entry to the master manifest
masterPlaylist.Append(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the Apple HLS spec, the master playlist is supposed to be in reverse descending order of bitrate then resolution. I think that's how the HLS players need the master playlist to be ordered (?). If so, I don't believe we're guaranteed to get the highest bitrate rendition first from the BOT flow. I added reverse sorting playlist logic in the previous flow that might help if the HLS spec is how it's supposed to be implemented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I created #94 to do it as a follow-up once transcoding is in. I'll have to look at the spec, but I seem to remember that they should be generally ordered like that but that there's some more subtle stuff around which one comes first

@thomshutt thomshutt merged commit 31303ae into main Oct 27, 2022
@thomshutt thomshutt deleted the write-manifests branch October 27, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants