-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transcode: trigger the transcode via remote or local broadcaster #98
Conversation
If the access-token is provided in the transcode request, the remote broadcaster (via livepeer.com) will be used to transcode. Otherwise, the local broadcaster will be used to transcode.
The transcoded segments are being returned correctly, but still needs a call to upload to s3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, LGTM
Codecov Report
@@ Coverage Diff @@
## main #98 +/- ##
===================================================
- Coverage 46.13527% 39.35957% -6.77570%
===================================================
Files 21 24 +3
Lines 1242 1499 +257
===================================================
+ Hits 573 590 +17
- Misses 598 833 +235
- Partials 71 76 +5
Continue to review full report at Codecov.
|
If the access-token is provided in the transcode request, the remote broadcaster (via livepeer.com) will be used to transcode. Otherwise, the local broadcaster will be used to transcode.