Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transcode: trigger the transcode via remote or local broadcaster #98

Merged
merged 5 commits into from
Oct 28, 2022

Conversation

emranemran
Copy link
Collaborator

If the access-token is provided in the transcode request, the remote broadcaster (via livepeer.com) will be used to transcode. Otherwise, the local broadcaster will be used to transcode.

If the access-token is provided in the transcode request, the remote
broadcaster (via livepeer.com) will be used to transcode. Otherwise, the
local broadcaster will be used to transcode.
@emranemran emranemran requested review from thomshutt and AlexKordic and removed request for thomshutt October 28, 2022 04:28
@emranemran emranemran marked this pull request as draft October 28, 2022 04:29
@emranemran
Copy link
Collaborator Author

The transcoded segments are being returned correctly, but still needs a call to upload to s3.

Copy link
Contributor

@AlexKordic AlexKordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM

@thomshutt thomshutt marked this pull request as ready for review October 28, 2022 09:54
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #98 (220a8d3) into main (3adef83) will decrease coverage by 6.77570%.
The diff coverage is 8.86525%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #98         +/-   ##
===================================================
- Coverage   46.13527%   39.35957%   -6.77570%     
===================================================
  Files             21          24          +3     
  Lines           1242        1499        +257     
===================================================
+ Hits             573         590         +17     
- Misses           598         833        +235     
- Partials          71          76          +5     
Impacted Files Coverage Δ
cache/transcoding.go 60.25641% <ø> (ø)
clients/broadcaster.go 0.00000% <0.00000%> (ø)
clients/broadcaster_local.go 0.00000% <0.00000%> (ø)
clients/broadcaster_remote.go 0.00000% <0.00000%> (ø)
clients/mist_client.go 49.14530% <ø> (ø)
transcode/transcode.go 43.58974% <46.51163%> (-1.14710%) ⬇️
handlers/misttriggers/recording_end.go 22.13115% <50.00000%> (+2.13115%) ⬆️
handlers/transcode.go 40.74074% <50.00000%> (ø)
transcode/manifest.go 72.41379% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95d823...220a8d3. Read the comment docs.

Impacted Files Coverage Δ
cache/transcoding.go 60.25641% <ø> (ø)
clients/broadcaster.go 0.00000% <0.00000%> (ø)
clients/broadcaster_local.go 0.00000% <0.00000%> (ø)
clients/broadcaster_remote.go 0.00000% <0.00000%> (ø)
clients/mist_client.go 49.14530% <ø> (ø)
transcode/transcode.go 43.58974% <46.51163%> (-1.14710%) ⬇️
handlers/misttriggers/recording_end.go 22.13115% <50.00000%> (+2.13115%) ⬆️
handlers/transcode.go 40.74074% <50.00000%> (ø)
transcode/manifest.go 72.41379% <100.00000%> (ø)

@thomshutt thomshutt merged commit 3abc75d into main Oct 28, 2022
@thomshutt thomshutt deleted the emran/transcode-with-remote-or-local-b branch October 28, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants