Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the input directly rather than from the URL for generating thumbnail #41

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Nov 6, 2023

No description provided.

@mjh1 mjh1 requested a review from leszko November 6, 2023 11:59
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #41 (68ccbed) into main (f21e006) will increase coverage by 0.09705%.
The diff coverage is 9.09091%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #41         +/-   ##
===================================================
+ Coverage   15.52795%   15.62500%   +0.09705%     
===================================================
  Files              2           2                 
  Lines            161         160          -1     
===================================================
  Hits              25          25                 
+ Misses           127         126          -1     
  Partials           9           9                 
Files Coverage Δ
core/uploader.go 20.16129% <9.09091%> (+0.16129%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21e006...68ccbed. Read the comment docs.

Files Coverage Δ
core/uploader.go 20.16129% <9.09091%> (+0.16129%) ⬆️

@mjh1 mjh1 merged commit 439a369 into main Nov 7, 2023
10 checks passed
@mjh1 mjh1 deleted the mh/read-segment branch November 7, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants