uploader: reinit TeeReader on upload retry to reset pointer #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On an upload fail and retry, teeReader would not be reset and would point to the end of the buffer being uploaded. We need to reset teeReader to begin reading from the beginning of fileContents again.
emranemran
force-pushed
the
emran/fix-teereader
branch
from
b794ab7
to
5b51b98
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
===================================================
- Coverage 16.75676% 16.57754% -0.17922%
===================================================
Files 2 2
Lines 185 187 +2
===================================================
Hits 31 31
- Misses 146 148 +2
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On an upload fail and retry, teeReader would not be reset and would point to the end of the buffer being uploaded. We need to reset teeReader to begin reading from the beginning of fileContents again.