Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api/views: Create new viewership BigQuery API #121

Merged
merged 10 commits into from
May 9, 2023
Merged

Conversation

victorges
Copy link
Member

@victorges victorges commented Apr 13, 2023

This implements the new Viewership V2 API in the analyzer service. It uses bigquery as the
data store and implements all the features proposed for the April project.

This implements DAT-62.

@victorges victorges requested a review from a team as a code owner April 13, 2023 22:09
@victorges victorges force-pushed the vg/feat/bigquery-views branch 3 times, most recently from 197e4c5 to 2bade05 Compare April 24, 2023 23:09
views/client.go Outdated Show resolved Hide resolved
views/client.go Outdated Show resolved Hide resolved
views/client.go Outdated Show resolved Hide resolved
views/client.go Outdated Show resolved Hide resolved
views/client.go Outdated Show resolved Hide resolved
views/client.go Outdated Show resolved Hide resolved
views/client.go Outdated Show resolved Hide resolved
views/client.go Outdated Show resolved Hide resolved
@victorges victorges force-pushed the vg/feat/bigquery-views branch 7 times, most recently from 4cbf3f2 to b2a54e7 Compare May 7, 2023 01:41
@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #121 (2241bd8) into main (dd30988) will increase coverage by 25.63291%.
The diff coverage is 27.27273%.

❗ Current head 2241bd8 differs from pull request most recent head 3d23fdd. Consider uploading reports for the commit 3d23fdd to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           main        #121          +/-   ##
===============================================
+ Coverage      0   25.63291%   +25.63291%     
===============================================
  Files         0           4           +4     
  Lines         0         316         +316     
===============================================
+ Hits          0          81          +81     
- Misses        0         223         +223     
- Partials      0          12          +12     
Impacted Files Coverage Δ
views/client.go 0.00000% <0.00000%> (ø)
views/prometheus.go 0.00000% <0.00000%> (ø)
views/bigquery.go 44.29530% <44.29530%> (ø)
views/dstorage.go 83.33333% <83.33333%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd30988...3d23fdd. Read the comment docs.

Impacted Files Coverage Δ
views/client.go 0.00000% <0.00000%> (ø)
views/prometheus.go 0.00000% <0.00000%> (ø)
views/bigquery.go 44.29530% <44.29530%> (ø)
views/dstorage.go 83.33333% <83.33333%> (ø)

api/authorization.go Outdated Show resolved Hide resolved
views/bigquery.go Outdated Show resolved Hide resolved
Copy link
Member

@gioelecerati gioelecerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments!

Re-ordered the shit out of bigquery handler
@victorges victorges merged commit 90c45b1 into main May 9, 2023
@victorges victorges deleted the vg/feat/bigquery-views branch May 9, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants