api/views: Better separate summary from events queries #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out after the initial version that the viewership summary and viewership
events tables don't actually have the same data: the summary one has the
prometheus data backward compatibility while the events one does not.
To make that distinction clearer to the end-user, added a new metric on the
summary query responses called
legacyViewCount
, which contains thenumber of views that have been migrated from the prometheus data and
thus will not show up in the detailed query endpoints.
Also removed a refactor that did a cheaper summary query when the
events query was made with just a playback ID. This is not possible anymore,
since the tables contain different data, so we cannot replace one query with
the other.
The coded ended up a little simpler tho, without magic attempt to detect what
kind of query it is, which could also lead to unexpected bugs like something
changing and we stopping the use of the summary table altogether.