Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix health status when multistream is disabled #162

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Fix health status when multistream is disabled #162

merged 3 commits into from
Aug 9, 2023

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Aug 2, 2023

No description provided.

@leszko leszko requested a review from victorges August 2, 2023 09:29
@leszko leszko marked this pull request as ready for review August 2, 2023 09:29
@leszko leszko requested a review from a team as a code owner August 2, 2023 09:29
victorges
victorges approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM either way only some questions/thought food

health/reducers/multistream.go Show resolved Hide resolved
health/reducers/multistream.go Show resolved Hide resolved
@leszko leszko merged commit 6fdd297 into main Aug 9, 2023
13 checks passed
@leszko leszko deleted the rafal/live-multistream branch August 9, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges victorges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leszko @victorges