Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

health: Fix yet another NRE and improve panic handling #172

Merged
merged 3 commits into from
Oct 4, 2023
Merged

health: Fix yet another NRE and improve panic handling #172

merged 3 commits into from
Oct 4, 2023

Conversation

victorges
Copy link
Member

This fixes another NRE found on the media server metrics code, which for some reason are getting some nil values sometimes.

Since we've been getting some of these frequently I also made some improvemenets to the panic handling code:

  • On the "rabbitmq stream consumer", include the message data in the panic log
  • On the "health core", recover from panics in reducers and skip the event instead of restarting the app

@victorges victorges requested a review from a team as a code owner September 22, 2023 15:22
gioelecerati
gioelecerati approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@gioelecerati gioelecerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorges victorges merged commit 31e37fc into main Oct 4, 2023
13 checks passed
@victorges victorges deleted the vg/fix/yanre branch October 4, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioelecerati gioelecerati gioelecerati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorges @gioelecerati