Fixing bugs from elastic#31599

lizozom · Feb 21, 2019 · 227413f · 227413f
1 parent cde4fa5
commit 227413f
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 9 deletions.
diff --git a/src/legacy/core_plugins/kibana/public/dashboard/index.js b/src/legacy/core_plugins/kibana/public/dashboard/index.js
@@ -70,9 +70,12 @@ uiRoutes
       $scope.find = (search) => {
         return services.dashboards.find(search, $scope.listingLimit);
       };
-      $scope.edit = ({ id }) => {
+      $scope.editItem = ({ id }) => {
         kbnUrl.redirect(createDashboardEditUrl(id));
       };
+      $scope.getEditUrl = ({ id }) => {
+        return createDashboardEditUrl(id);
+      };
       $scope.delete = (ids) => {
         return services.dashboards.delete(ids);
       };

diff --git a/src/legacy/core_plugins/kibana/public/dashboard/listing/dashboard_listing.js b/src/legacy/core_plugins/kibana/public/dashboard/listing/dashboard_listing.js
@@ -160,7 +160,7 @@ class DashboardListingUi extends React.Component {
         sortable: true,
         render: (field, record) => (
           <EuiLink
-            onClick={() => this.props.editItem(record)}
+            href={this.props.getEditUrl(record)}
             data-test-subj={`dashboardListingTitleLink-${record.title.split(' ').join('-')}`}
           >
             {field}
@@ -185,6 +185,7 @@ DashboardListingUi.propTypes = {
   findItems: PropTypes.func.isRequired,
   deleteItems: PropTypes.func.isRequired,
   editItem: PropTypes.func.isRequired,
+  getEditUrl: PropTypes.func.isRequired,
   listingLimit: PropTypes.number.isRequired,
   hideWriteControls: PropTypes.bool.isRequired,
   initialFilter: PropTypes.string,

diff --git a/src/legacy/core_plugins/kibana/public/dashboard/listing/dashboard_listing_ng_wrapper.html b/src/legacy/core_plugins/kibana/public/dashboard/listing/dashboard_listing_ng_wrapper.html
@@ -1,6 +1,7 @@
 <dashboard-listing
   create-item="create"
-  edit-item="edit"
+  get-edit-url="getEditUrl"
+  edit-item="editItem"
   find-items="find"
   delete-items="delete"
   listing-limit="listingLimit"

diff --git a/src/legacy/core_plugins/kibana/public/table_list_view/table_list_view.js b/src/legacy/core_plugins/kibana/public/table_list_view/table_list_view.js
@@ -62,8 +62,8 @@ class TableListViewUi extends React.Component {
       showLimitError: false,
       filter: this.props.initialFilter,
       selectedIds: [],
-      sortField: 'title',
-      sortDirection: 'asc',
+      sortField: '',
+      sortDirection: '',
       page: 0,
       perPage: 20,
     };

diff --git a/src/legacy/core_plugins/kibana/public/visualize/listing/visualize_listing.html b/src/legacy/core_plugins/kibana/public/visualize/listing/visualize_listing.html
@@ -34,7 +34,8 @@
     find-items="listingController.fetchItems"
     delete-items="listingController.deleteSelectedItems"
     create-item="listingController.createNewVis"
-    edit-item="listingController.edit"
+    get-edit-url="listingController.getEditUrl"
+    edit-item="listingController.editItem"
   ></visualize-listing-table>
 
   <new-vis-modal

diff --git a/src/legacy/core_plugins/kibana/public/visualize/listing/visualize_listing.js b/src/legacy/core_plugins/kibana/public/visualize/listing/visualize_listing.js
@@ -53,8 +53,12 @@ export function VisualizeListingController($injector, createNewVis) {
     this.showNewVisModal = true;
   };
 
-  this.edit = ({ id }) => {
-    kbnUrl.change(createVisualizeEditUrl(id));
+  this.editItem = ({ id }) => {
+    kbnUrl.redirect(createVisualizeEditUrl(id));
+  };
+
+  this.getEditUrl = ({ id }) => {
+    return createVisualizeEditUrl(id);
   };
 
   this.closeNewVisModal = () => {

diff --git a/src/legacy/core_plugins/kibana/public/visualize/listing/visualize_listing_table.js b/src/legacy/core_plugins/kibana/public/visualize/listing/visualize_listing_table.js
@@ -85,7 +85,7 @@ class VisualizeListingTableUi extends Component {
         sortable: true,
         render: (field, record) => (
           <EuiLink
-            onClick={() => this.props.editItem(record)}
+            href={this.props.getEditUrl(record)}
             data-test-subj={`visListingTitleLink-${record.title.split(' ').join('-')}`}
           >
             {field}
@@ -219,6 +219,7 @@ VisualizeListingTableUi.propTypes = {
   deleteItems: PropTypes.func.isRequired,
   findItems: PropTypes.func.isRequired,
   createItem: PropTypes.func.isRequired,
+  getEditUrl: PropTypes.func.isRequired,
   editItem: PropTypes.func.isRequired,
 };