Add Von Neumann topology #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #170 Fixed a bug in the topology class where not the best values were used as result when optimizing with the LocalBest class. Made the tests for the topologies less trivial by changing the index of the best cost and best position in the fixture swarm. Added a bigger fixture swarm to test the topology classes. Additionally, I fixed a little bug in the Random topology where the elements were compared to 0 instead of np.inf.
Reference: #129 Added a Von Neumann topology by inheriting from the Ring class and computing Delannoy numbers for the neighbours. Added tests and documentation and expanded the tests for the Ring topology.
ljvmiranda921
approved these changes
Jul 23, 2018
|
Yes, sorry hahaha. I just wanted this to be out 🙉 😋 Gonna keep that in mind! |
|
No probs! Good PR by the way! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a
VonNeumanntopology by inheriting from theRingtopology. Added the necessary tests and documentation. I also expanded the tests for theRingtopology.ATTENTION: This is built upon #176 so merge that one first.
Related Issue
See also: #129
Motivation and Context
This is the last topology that has to be added.
How Has This Been Tested?
Added the test file for the topology. Tested all function within the class.
Types of changes
Checklist: